Skip to content

Database interfaces and an implementation - #49

Merged
jparisu merged 13 commits into
mainfrom
feature/database
Mar 17, 2023
Merged

Database interfaces and an implementation#49
jparisu merged 13 commits into
mainfrom
feature/database

Conversation

@jparisu

@jparisu jparisu commented Mar 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Requirements:

ToDo:

  • code
  • test
  • code documentation (more or less)
  • version.md
  • uncrustify

@jparisu jparisu mentioned this pull request Mar 14, 2023
Merged
5 tasks
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 06:39 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 06:39 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 07:24 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 07:24 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 07:25 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 07:25 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 08:22 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 08:22 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 08:48 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 15, 2023 08:48 — with GitHub Actions Inactive
@codecov-commenter

codecov-commenter commented Mar 15, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 65.38% and project coverage change: -0.47 ⚠️

Comparison is base (e9ecdb3) 74.16% compared to head (fff2dd6) 73.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   74.16%   73.69%   -0.47%     
==========================================
  Files          58       59       +1     
  Lines        1045     1095      +50     
  Branches      251      270      +19     
==========================================
+ Hits          775      807      +32     
- Misses        131      133       +2     
- Partials      139      155      +16
Impacted Files Coverage Δ
cpp_utils/src/cpp/time/time_utils.cpp 73.33% <33.33%> (-5.24%) ⬇️
...pp_utils/collection/database/impl/SafeDatabase.ipp 66.66% <66.66%> (ø)
..._utils/include/cpp_utils/wait/impl/WaitHandler.ipp 87.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

irenebm
irenebm suggested changes Mar 15, 2023
View reviewed changes
Comment thread cpp_utils/test/unittest/user_interface/CommandReaderTest.cpp Outdated
Comment thread cpp_utils/test/unittest/user_interface/CMakeLists.txt Outdated
Comment thread cpp_utils/test/unittest/event/stdin_event/StdinEventHandlerTest.cpp Outdated
Comment thread cpp_utils/test/unittest/event/stdin_event/CMakeLists.txt Outdated
Comment thread cpp_utils/test/unittest/collection/database/CMakeLists.txt
Comment thread cpp_utils/include/cpp_utils/collection/database/SafeDatabase.hpp
Comment thread cpp_utils/include/cpp_utils/collection/database/SafeDatabase.hpp Outdated
Comment thread cpp_utils/test/unittest/collection/database/SafeDatabaseTest.cpp Outdated
Comment thread cpp_utils/test/unittest/collection/database/SafeDatabaseTest.cpp Outdated
Comment thread cpp_utils/test/unittest/collection/database/SafeDatabaseTest.cpp Outdated
@jparisu
jparisu temporarily deployed to codecov March 17, 2023 09:22 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 17, 2023 09:26 — with GitHub Actions Inactive
irenebm
irenebm previously approved these changes Mar 17, 2023
View reviewed changes

@irenebm irenebm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu
jparisu temporarily deployed to codecov March 17, 2023 09:45 — with GitHub Actions Inactive
irenebm
irenebm previously approved these changes Mar 17, 2023
View reviewed changes
jparisu
Implementation of Database
3f10ccd 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu added 12 commits March 17, 2023 11:05
jparisu
Implement SimpleDatabase
8368ac7 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
Add tests
eb4a1aa 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
Final design and implementation of Database
744681b 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
Add documentation to SafeDatabase
f51bc36 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
change shared_mutex for timed_shared_mutex
a9db3f2 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
move impl iterator to ipp
cbe7ac1 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
Add copy methods
fc1d725 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
fix windows problem
d065016 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
Fix error due to windows shared mutex design
c530d78 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
apply suggestions
993632e 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
apply suggestion in test
1389ac7 
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu
uncrustify
fff2dd6 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu
jparisu temporarily deployed to codecov March 17, 2023 10:05 — with GitHub Actions Inactive
@jparisu
jparisu temporarily deployed to codecov March 17, 2023 10:50 — with GitHub Actions Inactive
@jparisu
jparisu merged commit 86615e7 into main Mar 17, 2023
@jparisu
jparisu deleted the feature/database branch March 17, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@irenebm irenebm irenebm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jparisu @codecov-commenter @irenebm