-
-
Notifications
You must be signed in to change notification settings - Fork 23
Prepare CRAN release #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CRAN release #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[air] reported by reviewdog 🐶
modelbased/R/get_marginalmeans.R
Lines 24 to 32 in 18d47e1
| get_marginalmeans <- function(model, | |
| by = "auto", | |
| predict = NULL, | |
| ci = 0.95, | |
| estimate = NULL, | |
| transform = NULL, | |
| keep_iterations = FALSE, | |
| verbose = TRUE, | |
| ...) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on preparing the 'modelbased' R package for a new CRAN release. The changes primarily involve updating the package's version number, aligning its dependencies with the latest versions of related 'easystats' packages, and making corresponding adjustments throughout the codebase to ensure compatibility with these updated dependencies.
Highlights
- Version Update: The package version has been incremented from 0.12.0.22 to 0.13.0, signaling a new release.
- Dependency Updates: Minimum version requirements for several key dependencies have been updated, including bayestestR (to 0.17.0), insight (to 1.4.1), parameters (to 0.28.1), and marginaleffects (to 0.29.0).
- Remote Repository Configuration: The 'Remotes' field in the DESCRIPTION file has been adjusted to specifically reference a pull request in the 'parameters' package (easystats/parameters#1164), indicating a temporary dependency on an unreleased version of that package.
- Codebase Alignment: Numerous R source files and test files have been updated to reflect the new minimum version requirement for the 'marginaleffects' package, ensuring compatibility and leveraging new features or fixes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the modelbased package for a new CRAN release, version 0.13.0. The changes primarily involve updating the package version and its dependencies, most notably marginaleffects to version >= 0.29.0. These version updates are consistently applied across the DESCRIPTION file, R source files, and test files, which is great to see. The NEWS.md file is also correctly updated for the new release. The changes appear to be correct and well-executed for a release preparation. I found no issues of medium or higher severity.
easystats/parameters/pull/1164