-
-
Notifications
You must be signed in to change notification settings - Fork 103
Prepare CRAN release #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CRAN release #854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request prepares the performance R package for a new CRAN release by updating its version number and ensuring compatibility with recent changes in its dependencies. It specifically adjusts minimum version requirements for several key packages and refines the Remotes field to manage a specific dependency on a development version of modelbased, aligning with the broader goal of a stable release.
Highlights
- Version Update: The
performancepackage version has been incremented from0.15.0.3to0.15.1. - Dependency Updates: Minimum required versions for several imported and suggested packages have been updated, including
bayestestR,insight,glmmTMB, andparameters. - Modelbased Dependency: A minimum version requirement (
>= 0.13.0) has been added for themodelbasedpackage. - Remotes Field Adjustment: The
Remotesfield inDESCRIPTIONhas been modified to specifically point toeasystats/modelbased#560, indicating a focused dependency on a specific development version ofmodelbased.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the package for a new CRAN release by updating the version number, dependency versions, and the NEWS.md file. These changes are appropriate for a release. However, there is a critical issue in the DESCRIPTION file: the Remotes field has been updated, but for a CRAN release, this field must be removed entirely to pass CRAN checks. While this is noted in the PR description, it's a critical point to address before submission.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 61.90% 62.62% +0.72%
==========================================
Files 89 93 +4
Lines 6641 7227 +586
==========================================
+ Hits 4111 4526 +415
- Misses 2530 2701 +171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
easystats/modelbased/pull/560