Skip to content

Conversation

@strengejacke
Copy link
Member

@strengejacke strengejacke commented Aug 30, 2025

  • Remove Remotes-field once modelbased is on CRAN

easystats/modelbased/pull/560

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the performance R package for a new CRAN release by updating its version number and ensuring compatibility with recent changes in its dependencies. It specifically adjusts minimum version requirements for several key packages and refines the Remotes field to manage a specific dependency on a development version of modelbased, aligning with the broader goal of a stable release.

Highlights

  • Version Update: The performance package version has been incremented from 0.15.0.3 to 0.15.1.
  • Dependency Updates: Minimum required versions for several imported and suggested packages have been updated, including bayestestR, insight, glmmTMB, and parameters.
  • Modelbased Dependency: A minimum version requirement (>= 0.13.0) has been added for the modelbased package.
  • Remotes Field Adjustment: The Remotes field in DESCRIPTION has been modified to specifically point to easystats/modelbased#560, indicating a focused dependency on a specific development version of modelbased.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the package for a new CRAN release by updating the version number, dependency versions, and the NEWS.md file. These changes are appropriate for a release. However, there is a critical issue in the DESCRIPTION file: the Remotes field has been updated, but for a CRAN release, this field must be removed entirely to pass CRAN checks. While this is noted in the PR description, it's a critical point to address before submission.

@codecov
Copy link

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.62%. Comparing base (98f2f6a) to head (d224a93).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   61.90%   62.62%   +0.72%     
==========================================
  Files          89       93       +4     
  Lines        6641     7227     +586     
==========================================
+ Hits         4111     4526     +415     
- Misses       2530     2701     +171     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@strengejacke strengejacke merged commit 5057d0e into main Aug 30, 2025
18 of 20 checks passed
@strengejacke strengejacke deleted the rc_0_15_1 branch August 30, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants