Skip to content

Add call as attribute#572

Merged
strengejacke merged 4 commits into
mainfrom
add_call_attr
Sep 25, 2025
Merged

Add call as attribute#572
strengejacke merged 4 commits into
mainfrom
add_call_attr

Conversation

@strengejacke
Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a change to the modelbased package, specifically enhancing the output of key estimation functions by including the original function call as an attribute. This improvement allows for better traceability and reproducibility of results, as users can easily inspect how a function was invoked to produce a given output. The package version has also been incremented to reflect this update.

Highlights

  • Version Bump: The package version has been updated from "0.13.0.8" to "0.13.0.9" in the DESCRIPTION file.
  • Function Call Preservation: The original function call is now captured and stored as an attribute named "call" in the output of estimate_contrasts.default, estimate_means, and estimate_slopes functions using match.call().
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a call attribute to the objects returned by estimate_contrasts, estimate_means, and estimate_slopes. This is a valuable addition for reproducibility. I've made two main points in my review. First, the tests need to be updated to account for this new attribute, as they will currently fail. Second, for estimate_contrasts, I've suggested an improvement to ensure the stored call refers to the user-facing generic function (estimate_contrasts) rather than the internal method (estimate_contrasts.default), which is more conventional and user-friendly. The implementation for estimate_means and estimate_slopes looks good.

Comment thread R/estimate_contrasts.R Outdated
Comment thread R/estimate_contrasts.R Outdated
@strengejacke strengejacke merged commit 53e94da into main Sep 25, 2025
20 of 21 checks passed
@strengejacke strengejacke deleted the add_call_attr branch September 25, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant