-
-
Notifications
You must be signed in to change notification settings - Fork 23
tinyplot 0.6.0 #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tinyplot 0.6.0 #586
Conversation
Summary of ChangesHello @grantmcdermott, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces version 0.6.0 of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the tinyplot integration by simplifying the API, adding more flexibility with type and dodge parameters, and correctly handling legend titles. The removal of the dedicated theme argument in favor of passing theme options via ... makes the function more consistent with the tinyplot package. The updated examples and the heavily revised vignette are excellent, providing users with much clearer and more practical guidance on creating and customizing plots. The changes are well-thought-out and a great enhancement to the package. I've found one minor typo in the documentation that should be addressed.
Closes #585
I added
scalestoSuggeststo demo some label wrapping examples in the vignette. This should already be a recursive dependency ofsee(viaggplot2), so the net effect should be zero. But just wanted to give a HU.Some examples from the vignette below (note the "correct" legend title, better consistency when adding layers, etc.)
Created on 2025-11-28 with reprex v2.1.1