Plot estimated means - why connecting lines between groups?

[strengejacke]

Fixes #603

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue related to the default plotting behavior for estimated means in the modelbased package. It modifies the plot() method to no longer connect dots representing estimates with lines by default, providing users with more control over plot aesthetics. This change improves clarity by preventing potentially misleading connections between unrelated groups, aligning with the reported issue #603.

Highlights

• Default Plotting Behavior Change: The default value for the join_dots argument in plotting functions has been changed from TRUE to FALSE. This means that estimated means will no longer be connected by lines by default when plotting categorical focal terms.
• Breaking Change Notification: This modification is documented as a breaking change in the NEWS.md file, informing users of the altered default behavior.
• Documentation and Code Updates: The join_dots parameter's default has been updated across relevant R files and documentation to reflect the new FALSE setting, ensuring consistency.

Changelog

• DESCRIPTION
  • Updated package version from 0.14.0.1 to 0.14.0.2.
• NEWS.md
  • Added a 'Breaking Changes' section documenting the new default for join_dots.
• R/visualisation_recipe.R
  • Changed the default value of join_dots to FALSE in the visualisation_recipe.estimate_predicted function and its getOption fallback.
• R/visualisation_recipe_internal.R
  • Modified the default value of join_dots to FALSE in the internal visualisation_recipe_internal function.
• man/visualisation_recipe.estimate_predicted.Rd
  • Updated the documentation for the join_dots argument to reflect its new default value of FALSE.

Activity

• Addressed issue Plot estimated means - why connecting lines between groups? #603, which likely prompted this change in default plotting behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request changes the default behavior of the plot() method by setting the join_dots argument to FALSE by default. This prevents connecting dots with lines for categorical focal terms unless explicitly requested. The change is implemented consistently across the function definitions, option handling, and documentation. The package version has been appropriately incremented, and a breaking change notice has been added to NEWS.md. The changes are correct and adhere to the project's coding conventions.