Correct the sign of context effects#616
Merged
strengejacke merged 2 commits intomainfrom May 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the modelbased package to version 0.14.0.12, primarily changing the contrast calculation logic in get_contexteffects.R from diff(x) to revpairwise and removing the hypothesis column. These changes necessitated updates to the test suite and the 'practical context effect' vignette to account for flipped signs in the results. Feedback focuses on ensuring the sign of the contrast remains consistent with the documented 'Between - Within' definition, as revpairwise may have inverted it. Additionally, several inconsistencies in the vignette's text and statistical values need to be addressed to match the updated calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.