Skip to content

estimate_contrasts() gets a post_process argument#622

Merged
strengejacke merged 3 commits into
mainfrom
post_process_1
Jun 3, 2026
Merged

estimate_contrasts() gets a post_process argument#622
strengejacke merged 3 commits into
mainfrom
post_process_1

Conversation

@strengejacke
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new post_process argument to estimate_contrasts() and related functions to support multi-step comparisons and post-processing of results. It also updates documentation, adds corresponding tests, and makes minor adjustments to helper functions. However, two issues were identified in the review: first, a runtime error will occur in .guess_marginaltrends_arguments() because the variable dots is undefined; second, the newly added tests are unnecessarily skipped for R versions below 4.5.0, which would prevent them from running on current stable releases of R.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread R/get_marginaltrends.R
Comment thread tests/testthat/test-estimate_contrasts_post_process.R
@strengejacke strengejacke merged commit 547b1da into main Jun 3, 2026
14 of 20 checks passed
@strengejacke strengejacke deleted the post_process_1 branch June 3, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant