Add support for EFA/PCA from {psych} package#822
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the performance package's compatibility by integrating support for Factor Analysis and Principal Component Analysis models generated by the psych and parameters packages. Users can now seamlessly apply the package's diagnostic and performance assessment tools, such as normality checks, residual analysis, and model fit evaluation, to these widely used statistical models.
Highlights
- New Model Support: Extended the
performancepackage's diagnostic capabilities by adding S3 methods forcheck_normality,check_residuals, andmodel_performanceto support objects frompsych::fa(),psych::principal(), andparameters::factor_analysis(). - Performance Metrics for FA/PCA: Introduced a new
model_performance.famethod (also aliased forprincipalandparameters_efaobjects) that extracts key fit indices such as Chi-squared, degrees of freedom, p-value, RMSA, TLI, RMSEA (with confidence intervals), and BIC for Factor Analysis and Principal Component Analysis models. - Dependency Management: Updated the
DESCRIPTIONfile to includeeasystats/insightandeasystats/parametersin theRemotesfield, ensuring proper dependency resolution for the newly integrated functionalities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for EFA/PCA models from the {psych} package and parameters::factor_analysis() objects by implementing check_normality(), check_residuals(), and model_performance() methods. The core logic seems appropriate, but there are critical issues regarding documentation accuracy for model_performance.fa and robustness in handling potentially missing fit statistics from psych::principal objects. Additionally, the NEWS.md entry needs minor corrections for completeness and a typo.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
- Coverage 61.90% 61.90% -0.01%
==========================================
Files 89 92 +3
Lines 6641 6940 +299
==========================================
+ Hits 4111 4296 +185
- Misses 2530 2644 +114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #793