Conversation
Bump package version to 0.12.0 and update minimum ggplot2 dependency to 4.0.0. Refactor usage of geom_errorbarh to geom_errorbar with orientation='y' for compatibility with ggplot2 4.0.0.
|
Note The number of changes in this pull request is too large for Gemini Code Assist to generate a summary. |
|
A cool 25000 lines of code changed 😎 |
|
I changed the axis spacing, to fix the issue with narrow axis texts. What do you think? I could update the snapshot tests |
|
hm... for some plots, the spacing between axis line and text increased, for others, it decreases when using |
|
Yeah, I would leave it unchanged for now. Let's see if the users give any feedback about this. If they do, we can reassess. There is one example failing involving geom_from_list? Could you please have a look? |
|
Yes, will look into that failing test. |
|
This example fails, not sure why: # code from example:
ggplot() + geom_from_list(list(geom = "density_2d_raster", data = iris, aes = list(x = "Sepal.Width", y = "Petal.Length")))
# equivalent ggplot code
ggplot() +
geom_raster(
data = iris,
stat = "Density2d",
aes(x = Sepal.Width, y = Petal.Length, fill = after_stat(density)),
position = "identity"
) |
Source code changes are just 5-10 lines. Most of the other changes are just SVG changes in snapshots. Unfortunately, this is going to be the case every time there is a major ggplot2 release. |
Perhaps library(ggplot2)
ggplot()+
geom_raster(
data = iris,
aes(x = Sepal.Width, y = Petal.Length,fill = after_stat(density)),
stat= "Density2d",
position = "identity",
contour = FALSE
)Created on 2025-09-12 with reprex v2.1.1 |
Co-authored-by: Daniel <mail@danielluedecke.de>

Update minimum
ggplot2dependency to4.0.0.Refactor usage of
geom_errorbarhtogeom_errorbarwithorientation='y'for compatibility withggplot2 4.0.0.closes #409