internal/fakecgo: use riscv64 ABI macros for callee-saved register save/restore - #427
Merged
Conversation
…ve/restore In https://go-review.googlesource.com/c/go/+/749900 I added SAVE_GPR/RESTORE_GPR/SAVE_FPR/RESTORE_FPR macros to the Go toolchain for RISC-V. Pull down abi_riscv64.h with those macros and update asm_riscv64.s and trampolines_riscv64.s to use them instead of manually saving and restoring each callee-saved register.
gdams
changed the title
hajimehoshi
reviewed
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of issue is this addressing?
feature
What this PR does | solves
In https://go-review.googlesource.com/c/go/+/749900 I added SAVE_GPR/RESTORE_GPR/SAVE_FPR/RESTORE_FPR macros to the Go toolchain for RISC-V. Pull down abi_riscv64.h with those macros and update asm_riscv64.s and trampolines_riscv64.s to use them instead of manually saving and restoring each callee-saved register.