Comments frontend: Useable UI - #10454
Open
carlobeltrame wants to merge 9 commits into
Open
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
For now, it's easier to not allow access to outsiders. We can introduce this later if it's really needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This is especially relevant in the story overview and in the new comments panel. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
While loading collaborations, this helper is different from `!isOutsider`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Open
carlobeltrame
force-pushed
the
comments-frontend
branch
from
August 1, 2026 22:25
fef3ed9 to
2d07111
Compare
carlobeltrame
commented
Aug 1, 2026
Comment on lines
-44
to
-83
| { | ||
| "_links": { | ||
| "activity": { | ||
| "href": "escaped_value" | ||
| }, | ||
| "author": { | ||
| "href": "escaped_value" | ||
| }, | ||
| "camp": { | ||
| "href": "escaped_value" | ||
| }, | ||
| "self": { | ||
| "href": "escaped_value" | ||
| } | ||
| }, | ||
| "createTime": "escaped_value", | ||
| "id": "escaped_value", | ||
| "orphanDescription": "escaped_value", | ||
| "textHtml": "escaped_value" | ||
| }, | ||
| { | ||
| "_links": { | ||
| "activity": { | ||
| "href": "escaped_value" | ||
| }, | ||
| "author": { | ||
| "href": "escaped_value" | ||
| }, | ||
| "camp": { | ||
| "href": "escaped_value" | ||
| }, | ||
| "self": { | ||
| "href": "escaped_value" | ||
| } | ||
| }, | ||
| "createTime": "escaped_value", | ||
| "id": "escaped_value", | ||
| "orphanDescription": "escaped_value", | ||
| "textHtml": "escaped_value" | ||
| }, |
Member
Author
There was a problem hiding this comment.
Prototype camp comment and public camp comment were previously visible and now aren't anymore.
carlobeltrame
temporarily deployed
to
feature-branch
August 1, 2026 22:36 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
✅ Feature branch deployment ready!
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
carlobeltrame
force-pushed
the
comments-frontend
branch
from
August 2, 2026 08:37
2d07111 to
2e6f781
Compare
pmattmann
reviewed
Aug 2, 2026
Member
There was a problem hiding this comment.
Cool 🥳
-
I found one Bug:
- go to Activity-View
- create a Comment
- navigate to Camp-Overview
=> Comment-Side-View is still visible - but unusable (not event [X] is working)
-
Second bug:
- User-Menu (top right) is behind Comment-View
When Comment-View is visible, User-Menu is not usable
- User-Menu (top right) is behind Comment-View
An idea:
Can we add any indicator, that a activity has some comments.
Member
|
Really nice, thx! Some basic UI improvements:
Cool idea! The question is, if we should show this popup bubble, if it's not possible to "dismiss" it. Some people hate these things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the following points from #828 (comment):
Some further steps are already planned out and ready for being implemented.