Rust::com Method Rust APIs design and Example usage - #777
Closed
bharatGoswami8 wants to merge 10 commits into
Closed
Rust::com Method Rust APIs design and Example usage#777bharatGoswami8 wants to merge 10 commits into
bharatGoswami8 wants to merge 10 commits into
Conversation
* Created Method related interface traits * Updated Interface macro * created method related macro
* For generating type state pattern for method and field * Validating offer API call
* Added impl block for method interface
* Added impl block for method interface traits
* Updated import score_com crate
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
from
July 27, 2026 09:07
d1bde6f to
c8642b5
Compare
* Added method api usage in example app
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
from
July 27, 2026 09:36
c8642b5 to
7137981
Compare
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
4 times, most recently
from
July 27, 2026 11:13
cb6768b to
e7aa085
Compare
2 tasks
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
from
July 27, 2026 11:28
e7aa085 to
8171ac4
Compare
* Updated concept crate documentation * Updated interface macro document * Update type state macro document
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
3 times, most recently
from
July 28, 2026 03:30
7923efe to
a1955f2
Compare
* Updated return value to MethodReturnSample
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
2 times, most recently
from
July 28, 2026 04:56
c9d7b8a to
26f69b6
Compare
* Added design markdown file and diagrams
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
from
July 28, 2026 05:11
26f69b6 to
36d892c
Compare
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
2 times, most recently
from
July 28, 2026 10:02
068d0df to
5fe9e39
Compare
bharatGoswami8
commented
Jul 28, 2026
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
4 times, most recently
from
July 28, 2026 10:55
8a72901 to
9152d05
Compare
* Added MethodReturnSample for returning value at consumer side * MethodInArgPtr trait added for argument type
bharatGoswami8
force-pushed
the
Rust_Method_APIs_design
branch
from
July 28, 2026 11:23
9152d05 to
394cc7a
Compare
bharatGoswami8
marked this pull request as ready for review
July 28, 2026 11:24
bharatGoswami8
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
July 28, 2026 11:24
Contributor
Author
|
One combine PR created for Field and Method, and Field is using Method interface also both share same macro for interface and type-state pattern so i feel we should review on one PR both design so that suggestion or feedback can be address in better way. closing this PR. Please review mentioned PR. |
github-project-automation
Bot
moved this from In Progress
to Done
in COM - Communication FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit -
Since the Field and Method changes are related, and the Field implementation also uses the Method interface while both share the same macro for the interface and type-state pattern, I believe it would be better to review the overall design in a single PR. This will help ensure that any suggestions or feedback can be addressed more effectively and consistently across both implementations.
Therefore, I am closing this PR. Please review the PR - #818
#579