Resolve PR #2585 Change Requests

[darius-lesch]

The PR resolves two comments in #2585:

1. packages/core/src/util/setData.ts

The use of the loose != null was originally intentional, as it is a standard JavaScript shorthand to check for both null and undefined simultaneously. We can't use !data in this context because it would be unsafe; it would incorrectly reject valid falsy data values that we want to keep, such as 0, false, or an empty string "".

However, I completely agree that loose inequality can look like a typo or cause confusion at first glance. To make the intent strictly clear and avoid any "weirdness", I've updated the logic to use the explicit multiple cases as you suggested: data !== null && data !== undefined.

2. MIGRATION.md

I have also moved the data update path documentation into a new ## Migrating to JSON Forms 3.9 section in MIGRATION.md.

[darius-lesch]

@sdirix : Hope this helps resolve the change requests in PR #2585, get milestone 3.9 complete. and Let me know if there's anything else needed to get v3.9 shipped!

[sdirix]

Hi @darius-lesch, do you need JSON Forms 3.9 urgently shipped for your use cases? Would a pre-release of the current state be sufficient?

[darius-lesch]

Hi @darius-lesch, do you need JSON Forms 3.9 urgently shipped for your use cases? Would a pre-release of the current state be sufficient?

Hi @sdirix , no, there is no immediate urgency for my use cases. A pre-release of the current state is more than sufficient.

[lucas-koehler]

Hi @darius-lesch , thanks for the fixes ❤️
There is a small lint error due to expected formatting in the changed code line.

[darius-lesch]

Hi @darius-lesch , thanks for the fixes ❤️ There is a small lint error due to expected formatting in the changed code line.

Hi @lucas-koehler , linting issue has been resolved now.

[coveralls]

coverage: 84.286%. remained the same — darius-lesch:resolve/pr-2585-change-requests into eclipsesource:fix-2397

[lucas-koehler]

LGTM now, thanks for the update!

[lucas-koehler]

@darius-lesch a pre-release 3.9.0-alpha.0 should now be available containing all latest commits :)