Add StandaloneLinePlainConstructorParamFixer to spaces set#52
Merged
Conversation
… promoted properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructors with plain (non-promoted) params were not covered by any set rule.
StandaloneLinePromotedPropertyFixeronly fires when a promoted property is present, andStandaloneLineConstructorParamFixeris registered as conflicting with it, so it cannot be added to the same set.This adds
StandaloneLinePlainConstructorParamFixer, which handles exactly the gap: constructors that have params and no promoted properties. The two rules never touch the same constructor, so both live in the spaces set.final class LeadController { - public function __construct(CorePermissions $security, Translator $translator, RouterInterface $router, FormFactoryInterface $formFactory) + public function __construct( + CorePermissions $security, + Translator $translator, + RouterInterface $router, + FormFactoryInterface $formFactory + ) { } }One param per line keeps a new or removed dependency down to a single-line diff.
Skipped:
StandaloneLinePromotedPropertyFixer)__constructRegistered in
SpacesLevel::RULESnext to its sibling standalone-line rules, so it ships with the spaces set andwithSpacesLevel().Applying the rule to this repo reformatted one constructor in
TokenNotFoundException.