Skip StandaloneLinePlainConstructorParamFixer for 3 or fewer params#53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StandaloneLinePlainConstructorParamFixernow only splits constructors with 4 or more parameters. Short parameter lists stay readable on a single line.Skipped:
Still fixed:
final class PlainParams { - public function __construct(CorePermissions $security, Translator $translator, RouterInterface $router, Logger $logger) + public function __construct( + CorePermissions $security, + Translator $translator, + RouterInterface $router, + Logger $logger + ) { } }Param counting ignores tokens nested in default values, so
[1, 2]ornew Foo(1)defaults do not inflate the count. The previous empty-param-list guard is subsumed by the count check.