[9.0](backport #44188) [Flaky test] Give test filebeat receivers distinct home directories #44191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fbreceiver.TestMultipleReceivers` created two Filebeat receivers using the same config, which meant they both had the same home directory. This can cause conflicts that prevent a beat from starting, which is likely the cause of this test's [recent flakiness](https://buildkite.com/elastic/beats-xpack-filebeat/builds/14573#019691c7-e3d0-430b-83a1-334343b57ef0/97-593). This PR wraps the config in a helper function so the two receivers get different temporary directories. (cherry picked from commit d052026) # Conflicts: # x-pack/filebeat/fbreceiver/receiver_test.go
mergify
bot
added
backport
conflicts
mergify
bot
requested review from
mauri870 and
rdner
and removed request for
a team
Contributor
Author
|
Cherry-pick of d052026 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
github-actions
bot
added
flaky-test
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @faec? 🙏 |
mauri870
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fbreceiver.TestMultipleReceiverscreated two Filebeat receivers using the same config, which meant they both had the same home directory. This can cause conflicts that prevent a beat from starting, which is likely the cause of this test's recent flakiness. This PR wraps the config in a helper function so the two receivers get different temporary directories.This is an automatic backport of pull request #44188 done by [Mergify](https://mergify.com).