Add ms_tls13kdf tag when requirefips is passed #44227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
the
release-note:skip
michel-laterman
added
Team:Elastic-Agent-Control-Plane
botelastic
bot
added
the
needs_team
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
removed
the
needs_team
nicholasberlin
approved these changes
May 6, 2025
mauri870
approved these changes
May 6, 2025
AndersonQ
approved these changes
May 7, 2025
ycombinator
reviewed
May 7, 2025
ycombinator
reviewed
May 7, 2025
Contributor
ycombinator
left a comment
ycombinator
left a comment
There was a problem hiding this comment.
Should we also check for the ms_tls13kdf tag somewhere around here?
beats/dev-tools/packaging/package_test.go
Line 844 in ae4ef31
ycombinator
approved these changes
May 7, 2025
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2025
Add ms_tls13kdf tag when requirefips is passed (cherry picked from commit fff4a78)
michel-laterman
added a commit
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add the
ms_tls13kdfbuild tag to FIPS builds.microsoft/go TLSv1.3 kdf support (microsoft/go#1662) requires the
ms_tls13kdfbuild tag.