Skip to content

Fix struct OOB panic parser in Thrift#48498

Merged
fearful-symmetry merged 6 commits intoelastic:mainfrom
fearful-symmetry:thrift-struct-parse-offset-fix
Jan 27, 2026
Merged

Fix struct OOB panic parser in Thrift#48498
fearful-symmetry merged 6 commits intoelastic:mainfrom
fearful-symmetry:thrift-struct-parse-offset-fix

Conversation

@fearful-symmetry
Copy link
Contributor

Proposed commit message

This fixes a small bug in the Thrift struck parser, where a malformed packet can lead to a panic.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

@fearful-symmetry fearful-symmetry requested a review from a team as a code owner January 21, 2026 19:02
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2026
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2026

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Contributor

@nicholasberlin nicholasberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, but LGTM

@fearful-symmetry fearful-symmetry added Team:Security-Linux Platform Linux Platform Team in Security Solution backport-active-all Automated backport with mergify to all the active branches labels Jan 23, 2026
@elasticmachine
Copy link
Contributor

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 23, 2026
@fearful-symmetry fearful-symmetry merged commit b710eab into elastic:main Jan 27, 2026
40 checks passed
@github-actions
Copy link
Contributor

@Mergifyio backport 8.19 9.2 9.3

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

backport 8.19 9.2 9.3

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 27, 2026
* Fix struct parser array OOB

* add changelog

* linter...

* linter...

* format

* change if statement

(cherry picked from commit b710eab)
mergify bot pushed a commit that referenced this pull request Jan 27, 2026
* Fix struct parser array OOB

* add changelog

* linter...

* linter...

* format

* change if statement

(cherry picked from commit b710eab)
mergify bot pushed a commit that referenced this pull request Jan 27, 2026
* Fix struct parser array OOB

* add changelog

* linter...

* linter...

* format

* change if statement

(cherry picked from commit b710eab)
fearful-symmetry added a commit that referenced this pull request Jan 28, 2026
* Fix struct parser array OOB

* add changelog

* linter...

* linter...

* format

* change if statement

(cherry picked from commit b710eab)

Co-authored-by: Alex K. <8418476+fearful-symmetry@users.noreply.github.com>
fearful-symmetry added a commit that referenced this pull request Jan 28, 2026
* Fix struct parser array OOB

* add changelog

* linter...

* linter...

* format

* change if statement

(cherry picked from commit b710eab)

Co-authored-by: Alex K. <8418476+fearful-symmetry@users.noreply.github.com>
fearful-symmetry added a commit that referenced this pull request Jan 28, 2026
* Fix struct parser array OOB

* add changelog

* linter...

* linter...

* format

* change if statement

(cherry picked from commit b710eab)

Co-authored-by: Alex K. <8418476+fearful-symmetry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants