[winlogbeat] Disable Winlogbeat record ID gap detection when using xml_query#50443
Conversation
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
🤖 GitHub commentsJust comment with:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRecord ID gap detection in Winlogbeat has been modified to suppress detection when custom XML queries are configured. The change updates the gap detection logic in the wineventlog processing handler and includes a corresponding unit test to verify the behavior. A changelog fragment documents this bug fix, noting that filtered XML queries can produce non-contiguous record IDs without indicating genuine gaps requiring recovery. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 13 minutes and 7 seconds.Comment |
|
@Mergifyio backport 9.3 9.4 |
✅ Backports have been createdDetails
|
Proposed commit message
Disable Winlogbeat record ID gap detection when using xml_query so filtered queries do not loop on non-contiguous record IDs.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.