Skip to content

[8.19](backport #50492) x-pack/filebeat/input/streaming: apply configured timeout to OAuth2 token requests#50531

Merged
efd6 merged 1 commit into
8.19from
mergify/bp/8.19/pr-50492
May 6, 2026
Merged

[8.19](backport #50492) x-pack/filebeat/input/streaming: apply configured timeout to OAuth2 token requests#50531
efd6 merged 1 commit into
8.19from
mergify/bp/8.19/pr-50492

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 6, 2026

Proposed commit message

x-pack/filebeat/input/streaming: apply configured timeout to OAuth2 token requests

The CrowdStrike FalconHose input constructed the OAuth2 HTTP client
with only the Transport from the auth client, dropping the Timeout
set by httpcommon.HTTPTransportSettings. Token endpoint requests
could hang indefinitely instead of respecting the configured timeout.

Apply the timeout via context.WithTimeout in rateLimitTransport
rather than http.Client.Timeout to avoid the deprecated
oauth2.Transport.CancelRequest path.

Also fix flaky test.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #50492 done by [Mergify](https://mergify.com).

…oken requests (#50492)

The CrowdStrike FalconHose input constructed the OAuth2 HTTP client
with only the Transport from the auth client, dropping the Timeout
set by httpcommon.HTTPTransportSettings. Token endpoint requests
could hang indefinitely instead of respecting the configured timeout.

Apply the timeout via context.WithTimeout in rateLimitTransport
rather than http.Client.Timeout to avoid the deprecated
oauth2.Transport.CancelRequest path.

Also fix flaky test.

(cherry picked from commit fd8ae04)
@mergify mergify Bot added the backport label May 6, 2026
@mergify mergify Bot requested review from a team as code owners May 6, 2026 20:46
@mergify mergify Bot added the backport label May 6, 2026
@mergify mergify Bot removed the request for review from a team May 6, 2026 20:46
@mergify mergify Bot assigned efd6 May 6, 2026
@mergify mergify Bot requested review from AndersonQ and VihasMakwana May 6, 2026 20:46
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /test : Run the Buildkite pipeline.

@github-actions github-actions Bot added Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team labels May 6, 2026
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2026
@efd6 efd6 enabled auto-merge (squash) May 6, 2026 20:49
@efd6 efd6 merged commit ed72f29 into 8.19 May 6, 2026
32 of 35 checks passed
@efd6 efd6 deleted the mergify/bp/8.19/pr-50492 branch May 6, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant