fix(deps): bump click to 8.3.3 for CVE-2026-7246 - #4189
Merged
Jan-Kazlouski-elastic merged 8 commits intoJul 17, 2026
Conversation
Click <8.3.3 has command injection in click.edit(); bump the direct pin to the fixed release. Connectors does not call click.edit(), but the bump clears scanner findings. Closes elastic/security#12534 Co-authored-by: Cursor <cursoragent@cursor.com>
Click 8.2+ exits 2 for no_args_is_help and no longer applies prompt defaults on EOF, which broke create/help fixtures after the 8.3.3 bump. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Split Click option vs Mongo config prompts, assert indexed field alignment, and cover Click 8.2+ exit code 2 for bare subgroups. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the same invoke_without_command + manual help pattern as the root CLI so connector/index/job without a subcommand do not inherit Click's no_args_is_help exit code 2. Co-authored-by: Cursor <cursoragent@cursor.com>
erikcurrin-elastic
approved these changes
Jul 17, 2026
Jan-Kazlouski-elastic
enabled auto-merge (squash)
July 17, 2026 13:10
This was referenced Jul 17, 2026
💔 Failed to create backport PR(s)
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
Jan-Kazlouski-elastic
added a commit
that referenced
this pull request
Jul 17, 2026
Jan-Kazlouski-elastic
added a commit
that referenced
this pull request
Jul 17, 2026
Jan-Kazlouski-elastic
added a commit
that referenced
this pull request
Jul 17, 2026
Jan-Kazlouski-elastic
added a commit
that referenced
this pull request
Jul 20, 2026
Backports the following commits to 8.19: - fix(deps): bump click to 8.3.3 for CVE-2026-7246 (#4189) The 8.19 branch uses `requirements/framework.txt` (not the `main` layout), so the pin was applied there. The Click 8.2+ behavior changes from the original PR were ported to the 8.19 CLI: the `connector`/`index`/`job` groups now use `invoke_without_command` + manual help (bare invocation stays exit 0 instead of Click 8.2+ `no_args_is_help` exit 2), and the `connector create` tests were updated to feed explicit values for every prompt (Click 8.2+ no longer applies prompt defaults on EOF). Validated locally on Python 3.11: `tests/test_connectors_cli.py` passes (44 passed) with `click==8.3.3`, and `ruff check`/`ruff format --check` are clean. Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/security/issues/12534
Bump the direct
clickpin from8.1.7to8.3.3to clear CVE-2026-7246 (command injection inclick.edit()). Connectors does not callclick.edit(), so product impact is Not Affected; the bump is proactive for scanner/SBOM findings.CLI subgroups (
connector/index/job) now use the sameinvoke_without_command+ manual help pattern as the root CLI, so bare subgroup help still exits 0 under Click 8.2+ (avoidsno_args_is_helpexit 2). Create fixtures were updated for Click 8.2+ prompt/EOF behavior in tests and assert indexed field alignment.Scanner A/B (
CVE-2026-7246)Checklists
Pre-Review Checklist
config.yml.example)Changes Requiring Extra Attention
Release Note
Bump
clickto 8.3.3 to address CVE-2026-7246.