[8.19] fix(deps): bump click to 8.3.3 for CVE-2026-7246 (#4189) - #4236
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Jan-Kazlouski-elastic
requested review from
a team,
artem-shelkovnikov and
erikcurrin-elastic
July 20, 2026 12:28
Jan-Kazlouski-elastic
enabled auto-merge (squash)
July 20, 2026 12:28
erikcurrin-elastic
approved these changes
Jul 20, 2026
Jan-Kazlouski-elastic
disabled auto-merge
July 20, 2026 13:40
Jan-Kazlouski-elastic
enabled auto-merge (squash)
July 20, 2026 14:07
Jan-Kazlouski-elastic
added a commit
that referenced
this pull request
Jul 21, 2026
…VE-2026-34073, CVE-2026-26007) (#4238) (#4244) Backports the following commits to 8.19: - fix(deps): bump cffi to 2.0.0 to unblock cryptography 46.0.7 (CVE-2026-34073, CVE-2026-26007) (#4238) The automated backport could not cherry-pick #4238 because 8.19 uses the older layout: dependencies live in `requirements/framework.txt` (not `app/connectors_service/pyproject.toml`). The equivalent pin `cffi==1.16.0` -> `cffi==2.0.0` was applied there. `cryptography` is transitive and was capped at **46.0.0** by the old `cffi` pin (`cryptography` 46.0.5+ require `cffi>=2.0.0`). Bumping `cffi` lets it resolve to **46.0.7**, clearing: - **CVE-2026-26007** (fixed in 46.0.5) - **CVE-2026-34073** (fixed in 46.0.6) - **CVE-2026-39892** (fixed in 46.0.7) `pyOpenSSL==26.0.0` (already on 8.19 via #4232) provides the `cryptography` floor and keeps the ceiling at 46.x. ### Dependency resolution A/B (8.19, Python 3.11) Installing `requirements/x86_64.txt`: | `cffi` pin | resolved `cryptography` | |------------|-------------------------| | `1.16.0` (before) | `46.0.0` | | `2.0.0` (after) | `46.0.7` | ### NOTICE.txt (fully regenerated) `NOTICE.txt` was regenerated from the real resolved dependency tree via `make clean install autoformat lint test PYTHON=python3.11` (pip-licenses). It now reflects `cffi 2.0.0` and `cryptography 46.0.7`, and — because 8.19's `NOTICE.txt` had gone stale — it also captures drift that recent security backports left unwritten (aiohttp `3.11.10` -> `3.13.3` #4234, click `8.1.7` -> `8.3.3` #4236, pyOpenSSL `24.3.0` -> `26.0.0` #4232, pyasn1 `0.6.0` -> `0.6.4` #4233, elastic-agent-client `0.0.1.dev1` -> `0.0.2` / protobuf `5.27.5` -> `5.29.6` #4235, plus transitive updates). This brings `NOTICE.txt` into its cleanest, freshest state. ### Local validation (Python 3.11) `make clean install autoformat lint test PYTHON=python3.11`: - **2437 tests passed**, ruff `check`/`format --check` clean, coverage **92.39%** (>= 92% gate). - The single `--fail-slow` flag on `tests/sources/test_s3.py::test_close_with_client_session` is a timing-threshold artifact (`1.28s > 1.0s`, "Test passed but took too long"), not a functional failure. Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.19:
The 8.19 branch uses
requirements/framework.txt(not themainlayout), so the pin was applied there. The Click 8.2+ behavior changes from the original PR were ported to the 8.19 CLI: theconnector/index/jobgroups now useinvoke_without_command+ manual help (bare invocation stays exit 0 instead of Click 8.2+no_args_is_helpexit 2), and theconnector createtests were updated to feed explicit values for every prompt (Click 8.2+ no longer applies prompt defaults on EOF).Validated locally on Python 3.11:
tests/test_connectors_cli.pypasses (44 passed) withclick==8.3.3, andruff check/ruff format --checkare clean.Made with Cursor