Skip to content

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Aug 11, 2022

Addresses #2221.

A couple of notes about this PR:

Previews:

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon marked this pull request as ready for review August 12, 2022 18:29
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one totally optional suggestion.

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@nastasha-solomon nastasha-solomon added the readyforQA PRs that are ready for QA review. label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

Hi @jmikell821

we have reviewed the shared preview for Update Host Risk Score Setup process and all the required change are present and correct. ✔️

image

image

Hence we are adding "QA:Validated" label to it.

thanks !!

@ghost ghost added QA:Validated Issue has been Validated by QA Team and removed readyforQA PRs that are ready for QA review. labels Aug 17, 2022
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulleted list looks much cleaner. LGTM! 👍

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nastasha-solomon nastasha-solomon merged commit 8a1f28d into main Aug 18, 2022
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 8a1f28d)
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 24, 2022
20 tasks
nastasha-solomon added a commit to nastasha-solomon/security-docs that referenced this pull request Sep 19, 2022
…#2221 (backport elastic#2297) (elastic#2326)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Cases Cases issues QA:Validated Issue has been Validated by QA Team Team: Docs Team: ResponseOps Team: Threat Hunting Formerly Data Visibility v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants