Skip to content

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 25, 2022

Addresses the following issues:

Previews:

@nastasha-solomon nastasha-solomon changed the title [DOCS] Consider a widget to focus info in connector topic [DOCS] Structural changes to connector topic Jul 25, 2022
@nastasha-solomon nastasha-solomon changed the title [DOCS] Structural changes to connector topic [DOCS] Revising tables in connector topic Jul 25, 2022
@nastasha-solomon nastasha-solomon marked this pull request as ready for review August 3, 2022 19:00
@nastasha-solomon nastasha-solomon changed the title [DOCS] Revising tables in connector topic [DOCS] Changes to sections for configuring connectors and mapped case fields Aug 3, 2022
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, left a few minor suggestions and one question.

* *API token*: The {swimlane} API authentication token is used for HTTP Basic authentication.
This is the personal access token for your user role.
* *Connector Type*: Select a connector type:
*** *All*: You can choose to set all or no field mappings when creating your new {swimlane} connector. However, note that if you don’t set field mappings now, you’ll be prompted to do so if you want to use the connector for a case or a rule.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*** *All*: You can choose to set all or no field mappings when creating your new {swimlane} connector. However, note that if you don’t set field mappings now, you’ll be prompted to do so if you want to use the connector for a case or a rule.
*** *All*: You can choose to set all or no field mappings when creating your new {swimlane} connector. However, note that if you don’t set field mappings now, you’ll be prompted to do so before you use the connector for a case or a rule.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a dumb question because I've never tried out a Swimlane connector, but does this not apply to the other two options here ("Alerts" and "Cases")? I.e. do you not have to map fields if you select one of those? It reads like you don't, so just confirming.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a dumb question and you're correct! I'll move this to a note under the parent bullet (so under Connector Type) because it does apply to all the types.

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome reorganization! Forget I ever said anything about a widget; this is clean and easy to follow, and will be easier to maintain, too. One tiny tweak below.

nastasha-solomon and others added 7 commits August 4, 2022 15:45
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
@nastasha-solomon
Copy link
Contributor Author

Might encounter a merge conflict after pull in changes from #2297. Should accept the changes from this PR.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2097-widget upstream/issue-2097-widget
git merge upstream/main
git push upstream issue-2097-widget

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reorging this! 🎉

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2022

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-2097-widget upstream/issue-2097-widget
git merge upstream/main
git push upstream issue-2097-widget

@nastasha-solomon
Copy link
Contributor Author

Opened #2417 to start fresh. When I merged in changes from the remote main branch, the changes got applied to my local project branch and then pushed back up the PR - hence the merge conflicts and numerous updated files.

@nastasha-solomon nastasha-solomon deleted the issue-2097-widget branch August 31, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

5 participants