-
Notifications
You must be signed in to change notification settings - Fork 206
[DOCS] Changes to sections for configuring connectors and mapped case fields #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, left a few minor suggestions and one question.
| * *API token*: The {swimlane} API authentication token is used for HTTP Basic authentication. | ||
| This is the personal access token for your user role. | ||
| * *Connector Type*: Select a connector type: | ||
| *** *All*: You can choose to set all or no field mappings when creating your new {swimlane} connector. However, note that if you don’t set field mappings now, you’ll be prompted to do so if you want to use the connector for a case or a rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| *** *All*: You can choose to set all or no field mappings when creating your new {swimlane} connector. However, note that if you don’t set field mappings now, you’ll be prompted to do so if you want to use the connector for a case or a rule. | |
| *** *All*: You can choose to set all or no field mappings when creating your new {swimlane} connector. However, note that if you don’t set field mappings now, you’ll be prompted to do so before you use the connector for a case or a rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a dumb question because I've never tried out a Swimlane connector, but does this not apply to the other two options here ("Alerts" and "Cases")? I.e. do you not have to map fields if you select one of those? It reads like you don't, so just confirming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a dumb question and you're correct! I'll move this to a note under the parent bullet (so under Connector Type) because it does apply to all the types.
joepeeples
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome reorganization! Forget I ever said anything about a widget; this is clean and easy to follow, and will be easier to maintain, too. One tiny tweak below.
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
|
Might encounter a merge conflict after pull in changes from #2297. Should accept the changes from this PR. |
|
This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏 |
…into issue-2097-widget
jmikell821
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reorging this! 🎉
|
This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏 |
|
Opened #2417 to start fresh. When I merged in changes from the remote |
Addresses the following issues:
Previews: