[DOCS] Consolidates info for mapped case fields #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepeeples
reviewed
Aug 31, 2022
Contributor
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
The info here looks good -- added some suggestions to trim down the table and omit unnecessary filler and repetition, so it's easier for the reader to focus on the key info. Here's what the trimmed-down table would look like rendered:
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
nastasha-solomon
requested review from
benironside,
jmikell821 and
joepeeples
benironside
reviewed
Sep 12, 2022
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
LGTM, left one suggestion.
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
jmikell821
reviewed
Sep 13, 2022
Contributor
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
Added a slight nit for a comma suggestion, other than that LGTM!
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> (cherry picked from commit 134445b)
nastasha-solomon
added a commit
that referenced
this pull request
Sep 13, 2022
#2454) Co-authored-by: Joe Peeples <joe.peeples@elastic.co> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com> Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2100 and #2098.
This PR re-adds the section for mapped fields, which looks to have been removed in 8.4. The re-added section contains the changes made in #2220.
Preview here.