electron-builder custom NSIS include script macro not working

[alokmahor]

• Version: 22.10.5

• Electron Version: 11.1.0
• Electron Type (current, beta, nightly): current

• Target: Windows 10

I have created a electron desktop app and created a installer using electron-builder.

Now I want to try macro like customInstall and customUnInstall

My installer.nsh file is

!macro customInstall
  MessageBox MB_OK "Test output 1"
!macroend

!macro customUnInstall
  MessageBox MB_OK "Test output 2"
!macroend

My electron-builder config is

"build": {
    "nsis": {
      "include": "installer.nsh"
    },
    "mac": {
      "icon": "build/icon.png"
    },
    "win": {
      "icon": "build/icon.png"
    }
  }

But this is not working for me.
What I am missing to make it working?

[mmaietta]

Why did you create two tickets for the same electron builder config with the same request for customInstall and customUnInstall. If this one isn't working, then neither would the other installer script.

Looking at the code, it seems the installer.nsh is explicitly required to be a path relative to your project dir or resources dir. Can you confirm that you're configured correctly?

electron-builder/packages/app-builder-lib/src/platformPackager.ts

Lines 566 to 578 in 8df250b

	const resourceList = await this.resourceList
	if (resourceList.includes(custom)) {
	return path.join(resourcesDir, custom)
	}
	let p = path.resolve(resourcesDir, custom)
	if ((await statOrNull(p)) == null) {
	p = path.resolve(this.projectDir, custom)
	if ((await statOrNull(p)) == null) {
	throw new InvalidConfigurationError(`cannot find specified resource "${custom}", nor relative to "${resourcesDir}", neither relative to project dir ("${this.projectDir}")`)
	}
	}
	return p

[alokmahor]

I have confirmed that installer.nsh is working by introducing error in that.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[GeorgeFlorian]

I also have this issue !