Internal: Remove per-event app_type in favor of events-manager super property [ED-24820]

[Ntnelbaba]

Summary

• Remove redundant per-event app_type from all editor event dispatch payloads across legacy JS, packages, and onboarding analytics.
• Keep appType: 'Editor' registered via events-manager enableTracking() as the single source of truth for editor context on every event.
• window_name and appTypes config entries are unchanged — still used for context-specific window identification.

Test plan

• npm run test:jest -- --testPathPattern=editor-one-events-wpdash
• Verify dispatched events in editor still include appType: Editor via super property (no per-event app_type)
• Smoke-test publish dropdown, page list, onboarding, and pro-install connect flows

Ref: ED-24820

Made with Cursor

✨ PR Description

1. Problem & Context

Removing redundant app_type: 'editor' properties from event payloads across the codebase—this property is now managed centrally by the events manager as a super property (ED-24820), eliminating duplication and reducing payload overhead.

2. What Changed (Where)

Category	Files
Onboarding events	packages/apps/onboarding/src/analytics/events.ts, onboarding-tracking.ts
Editor app-bar	5 files in documents-save/hooks/, use-document-*.ts
Editor interactions & navigation	editor-interactions/src/utils/tracking.ts, editor-site-navigation/src/components/top-bar/*.tsx
Core editor controls & commands	assets/dev/js/editor/document/elements/commands/delete.js, editor/utils/editor-one-events.js, packages/libs/editor-controls/src/utils/tracking.ts
Pro install events & tests	modules/pro-install/assets/js/pro-install-events.js, tests/jest/unit/assets/dev/js/editor/utils/editor-one-events-wpdash.test.js

3. How It Works

Event payloads previously included explicit app_type: 'editor' at dispatch time. This PR removes those lines from 13 files and 2 test files, relying on the centralized events manager to inject app_type as a super property automatically. No behavioral change—just cleaner payload construction and single source of truth.

4. Risks

Low risk. Change is mechanical and localized. Verify the events manager properly applies app_type super property in production; if not configured, analytics will lose this dimension. Test coverage via updated test assertions confirms payload structure.

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how}

[github-actions]

Review Summary

✅ Overall: Focused, low-risk cleanup that correctly centralizes appType via events-manager register(). Test assertions updated for wpdash events; all dispatch paths route through events-manager.

Issues (1)

1. 📝 Indentation regression in create-post-list-item.tsx and post-list-item.tsx — see inline comment.

[github-actions]

Elementor Build

Last updated at: 20260701.1124
Version: 4.3.0-20260701.1124

✅ Elementor build is ready for download.

You can download the latest build from the link below:

🔗 elementor-4.3.0-20260701.1124.zip

The build is available for 3 days.