Highlight home snippets using shiki#1834
Merged
Merged
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the simple elixir tokenizer with shiki (already used by blog posts). Currently it uses github-dark theme (the blog posts use github-light), I think it fits quite nicely and definitely makes the examples more readable.
The use cases snippets and the editor examples are all highlighted at build time. For the highlighting on changes, we load a separate highlighter JS chunk, only once the user focuses the editor. The editor is mostly for small snippets, so highlighting latency should not be an issue. I also pasted a 500 LOC file and even there editing works smoothly.