Remove usage of global Em#117
Merged
stefanpenner merged 1 commit intoember-cli:masterfrom Aug 5, 2015
Merged
Conversation
Member
|
Can you remove from .jshintrc also? |
HeroicEric
force-pushed
the
add-missing-imports
branch
from
6d84302 to
ea0c761
Compare
Member
|
@HeroicEric could you merge master/rebase. |
HeroicEric
force-pushed
the
add-missing-imports
branch
from
ea0c761 to
ea5e173
Compare
Contributor
Author
|
@joostdevries updated |
Contributor
There was a problem hiding this comment.
can we instead do
const { computed } = Emberthis will be nice once we cut over to the module API.
Contributor
Author
There was a problem hiding this comment.
For sure. Didn't want to start making style decisions but I'm 👍 if you all are
Contributor
Author
There was a problem hiding this comment.
@stefanpenner Updated that one and a few more that I came across
HeroicEric
force-pushed
the
add-missing-imports
branch
from
ea5e173 to
5a0390a
Compare
HeroicEric
force-pushed
the
add-missing-imports
branch
from
5a0390a to
5dbdfd7
Compare
stefanpenner
added a commit
that referenced
this pull request
Aug 5, 2015
Remove usage of global `Em`
Contributor
|
nice thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing imports of
Emberand removes usage of globalEm