Extract build-messages component#137
Merged
rwjblue merged 3 commits intoember-cli:masterfrom Aug 8, 2015
Merged
Conversation
Member
|
Looks great! Can you add some cursory integration tests for the new component? |
Contributor
Author
|
@rwjblue Just did. |
Member
There was a problem hiding this comment.
This cleanup needs to be in the afterEach (in case the test fails we don't want to leave it in an invalid state).
Contributor
Author
|
@rwjblue Comments addressed. |
Member
|
@Gaurav0 - Awesome, thanks for the tests (you must have pushed right when I was commenting, sorry about that)! |
rwjblue
added a commit
that referenced
this pull request
Aug 8, 2015
Extract build-messages component
Contributor
Author
|
@rwjblue No problem. The component wasn't working quite right too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.