"Run now" reloads app#221
Merged
Gaurav0 merged 3 commits intoember-cli:masterfrom Oct 19, 2015
pangratz:run-now-reloads-app
Merged
"Run now" reloads app#221Gaurav0 merged 3 commits intoember-cli:masterfrom pangratz:run-now-reloads-app
Gaurav0 merged 3 commits intoember-cli:masterfrom
pangratz:run-now-reloads-app
Conversation
Contributor
There was a problem hiding this comment.
I think you may need to move this inside previous andThen
Contributor
Author
There was a problem hiding this comment.
You are right, nice catch.
The used `{{dummy-demo-app}}` component only reloads the application if
the passed `html` property changes. If nothing changes in the underlying
app, succeeding clicks on "run now" will do nothing, as the HTML doesn't
change.
To force enable the reload of the application, this commit adds a new
`<meta name="build-at" >` tag, which' value is set to the milliseconds
since the Unix Epoch. By this, the HTML changes everytime the app is
build and now the "run now" button always reloads the application.
Some acceptance tests fail since the <iframe> which contains the app is not yet loaded and hence the assertions on the content fail. This commit adds the previously `waitForLoadedIFrame()` helper so it is ensured that the iframe is loaded before the asserions are made.
Contributor
|
👍 |
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The used
{{dummy-demo-app}}component only reloads the application ifthe passed
htmlproperty changes. If nothing changes in the underlyingapp, succeeding clicks on "run now" will do nothing, as the HTML doesn't
change.
To force enable the reload of the application, this commit adds a new
<meta name="build-at" >tag, which' value is set to the millisecondssince the Unix Epoch. By this, the HTML changes everytime the app is
build and now the "run now" button always reloads the application.
This addresses #220