Dependencies refactoring#226
Merged
rwjblue merged 4 commits intoember-cli:masterfrom Oct 22, 2015
pangratz:dependencies-refactoring
Merged
Dependencies refactoring#226rwjblue merged 4 commits intoember-cli:masterfrom pangratz:dependencies-refactoring
rwjblue merged 4 commits intoember-cli:masterfrom
pangratz:dependencies-refactoring
Conversation
Member
|
🎉 |
Member
There was a problem hiding this comment.
Can you share this files array instead of duplicating in both tests?
Member
|
I left a few minor comments, but this is looking awesome! |
If the version is specified for "ember", "ember-data" or
"ember-template-compiler" in the twiddle.json, then it is resolved
accordingly:
```json
{
"dependencies": {
"ember": "1.13.8",
"ember-data": "1.13.3",
"jquery": "http://link.to/jquery.js"
}
}
```
resolves to
```json
{
"dependencies": {
"ember": "http://cdn-url.com/path/to/ember.js",
"ember-data": "http://cdn-url.com/path/to/ember-data.js",
"jquery": "http://link.to/jquery.js"
}
}
```
This method updated the version of a given dependency for the specified
gist:
emberCli.updateDependencyVersion(gist, 'ember', 'release');
Contributor
Author
|
Done. Thanks for se review! Further refactoring so the default |
Member
There was a problem hiding this comment.
if this uses {{action versionSelected "ember" version}} you can remove the actions section from app/components/versions-menu.js (the {{action helper accepts a function, which a closure action is).
Contributor
Author
There was a problem hiding this comment.
Oh, now I get it. Never used the closure actions before. Thanks for the lecture 👍 🎓
This adds a new menu "Dependencies" to the menu bar, which shows selectable versions for ember and ember-data. The versions include the release channels (release, beta, canary) as well as 3-4 of the latest releases. If a version is selected, the corresponding dependency is updated in the twiddle.json.
Member
|
👍 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember,ember-template-compilerandember-datarelease,betaandcanaryemberandember-datavia UI