Write a routing acceptance test#85
Merged
joostdevries merged 6 commits intoember-cli:masterfrom Jul 28, 2015
Merged
Conversation
Gaurav0
changed the title
Contributor
Author
|
I got it working!!! Please review. |
Member
There was a problem hiding this comment.
Can we store this in config/environment.js? That allows us to have a different value in the test environment from development/production, and should allow you to remove the host computed.
Contributor
Author
|
@rwjblue Updated. |
Contributor
Author
There was a problem hiding this comment.
The main reason I haven't done so is that this uses closure over login, gist_id, and commit.
joostdevries
pushed a commit
that referenced
this pull request
Jul 28, 2015
Write a routing acceptance test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an acceptance test using ember-cli-mirage and a whole bunch of interesting hacks.