Create runGist helper; minimal gist acceptance test#94
Merged
rwjblue merged 4 commits intoember-cli:masterfrom Jul 28, 2015
Merged
Create runGist helper; minimal gist acceptance test#94rwjblue merged 4 commits intoember-cli:masterfrom
rwjblue merged 4 commits intoember-cli:masterfrom
Conversation
Member
|
I actually like this a lot :-) |
Member
|
@rwjblue what do you think? |
Member
There was a problem hiding this comment.
This only needs to happen once, when the module is loaded. Including it here (inside the startApp function) will have this ran once for each acceptance test.
I prefer to have the run-gist helper imported and registered in tests/test-helper.js. Any objections?
Contributor
Author
|
@joostdevries @rwjblue Updated with suggested changes. |
Member
|
Awesome! Thank you! |
rwjblue
added a commit
that referenced
this pull request
Jul 28, 2015
Create runGist helper; minimal gist acceptance test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant to issue #84