Skip to content

chore(classy): Unify on_run_level hooks - #216

Merged
ieQu1 merged 2 commits into
release-1-1from
dev/classy-0.1.9
Jul 28, 2026
Merged

chore(classy): Unify on_run_level hooks#216
ieQu1 merged 2 commits into
release-1-1from
dev/classy-0.1.9

Conversation

@ieQu1

@ieQu1 ieQu1 commented Jul 28, 2026

Copy link
Copy Markdown
Member

Update classy version. The changes include the ability to automatically reverse the order of run_level hook execution, so hi/low hooks are no longer needed.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 1136

Warning

No base build found for commit ed1ddea on release-1-1.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 55.565%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 2453
Covered Lines: 1363
Line Coverage: 55.56%
Coverage Strength: 10937.05 hits per line

💛 - Coveralls

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates MRIA’s integration with classy run-level hooks by moving from separate “high/low” callbacks to a unified on_run_level/2 hook (paired with a classy dependency bump), and adds a simple readiness signal that CT fixtures can wait on.

Changes:

  • Bump classy dependency to 0.1.9 and switch MRIA to a single on_run_level/2 callback.
  • Add mria_app:ready/0 backed by an optvar flag set/unset on relevant run-level transitions.
  • Update the join test fixture to wait for both peer membership and MRIA readiness after joining.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/mria_join_fixture.erl Adds post-join retries to wait for peer visibility and MRIA readiness.
src/mria_app.erl Unifies run-level hooks into on_run_level/2 and introduces ready/0 readiness flag.
rebar.config Updates classy dependency version to support unified run-level hook API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/mria_app.erl Outdated
Comment thread test/mria_join_fixture.erl Outdated
@ieQu1
ieQu1 force-pushed the dev/classy-0.1.9 branch from c7e2261 to a9b35e0 Compare July 28, 2026 21:09
@ieQu1
ieQu1 force-pushed the dev/classy-0.1.9 branch from a9b35e0 to a9b953f Compare July 28, 2026 21:13
@ieQu1
ieQu1 merged commit ff075a8 into release-1-1 Jul 28, 2026
2 checks passed
@ieQu1
ieQu1 deleted the dev/classy-0.1.9 branch July 28, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants