chore(classy): Unify on_run_level hooks - #216
Conversation
Coverage Report for CI Build 1136Warning No base build found for commit Coverage: 55.565%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR updates MRIA’s integration with classy run-level hooks by moving from separate “high/low” callbacks to a unified on_run_level/2 hook (paired with a classy dependency bump), and adds a simple readiness signal that CT fixtures can wait on.
Changes:
- Bump
classydependency to0.1.9and switch MRIA to a singleon_run_level/2callback. - Add
mria_app:ready/0backed by anoptvarflag set/unset on relevant run-level transitions. - Update the join test fixture to wait for both peer membership and MRIA readiness after joining.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/mria_join_fixture.erl |
Adds post-join retries to wait for peer visibility and MRIA readiness. |
src/mria_app.erl |
Unifies run-level hooks into on_run_level/2 and introduces ready/0 readiness flag. |
rebar.config |
Updates classy dependency version to support unified run-level hook API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update classy version. The changes include the ability to automatically reverse the order of
run_levelhook execution, so hi/low hooks are no longer needed.