Allow linker flags to pass through to wasm-ld by default.#10747
Allow linker flags to pass through to wasm-ld by default.#10747
Conversation
emcc.py
Outdated
| if using_lld: | ||
| for flag, takes_arg in UNSUPPORTED_LLD_FLAGS.items(): | ||
| if f.startswith(flag): | ||
| shared.warning('ignoring unsupported linker flag: `%s`', f) |
There was a problem hiding this comment.
I guess this code was just moved around, but maybe this should integrate with the warning manager?
There was a problem hiding this comment.
I'll do that as part of the outstanding warning manager changes.
|
I imagine there will be more linker flags we need to add to this list, but it should be a finite about of work to get them added. |
44b2645 to
8a545de
Compare
|
At first glance I'm not sure of the impact. |
|
I seem to be getting unrelated build errors when trying to build renpyweb: Seems to be releated to the |
8a545de to
e87a69c
Compare
|
This patch seems to depend on others (since 1.39.11), it doesn't apply cleanly and I can't test, but for the record here's a matching log excerpt of |
|
I'd like to go ahead and land this, and then add the blacklist as we get reports from the wild about flags that people want to be able to use (but are not supported by wasm-ld). |
Rather then maintain an ever growing whitelist of supported linker flags, instead list the linker flags that we want to explicitly ignore for compatibility purposed with existing build systems.
e87a69c to
151dd6d
Compare
Rather then maintain an ever growing whitelist of supported linker
flags, instead list the linker flags that we want to explicitly ignore
for compatibility purposed with existing build systems.