Prevent transferredCanvasNames is not iterable (fixes #17751) #17752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Sep 2, 2022
|
Can we add a test? |
|
A test would be good, but as this is a fix for a regression, we should land this before making a new release. If adding a test would take time, we can maybe add the test later? |
Sure we can land this... it looks like there is the potential for follow to try to clean up all the transferredCanvasNames checks in this file.. and add a test. |
sbc100
approved these changes
Sep 6, 2022
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #17577 and fixes #17751