library_pthread.js: Ensure transferredCanvasNames is iterable #22623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
transferredCanvasNames
branch
from
77435b0 to
d491736
Compare
kripken
approved these changes
Sep 25, 2024
|
|
||
| @parameterized({ | ||
| '': ([],), | ||
| 'offscreen_canvas': (['-sOFFSCREENCANVAS_SUPPORT', '-sDEFAULT_LIBRARY_FUNCS_TO_INCLUDE=$GL'],), |
There was a problem hiding this comment.
Why is GL needed? I don't see it used in the test.
There was a problem hiding this comment.
From library_pthread.js:
#if ASSERTIONS
assert(typeof GL == 'object', 'OFFSCREENCANVAS_SUPPORT assumes GL is in use (you can force-include it with \'-sDEFAULT_LIBRARY_FUNCS_TO_INCLUDE=$GL\')');
#endif
d491736 to
78f8f55
Compare
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
force-pushed
the
transferredCanvasNames
branch
from
78f8f55 to
2586e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first broken back in #17577 and then fixed in #17752.
I then broke it again in #22545 (yay!) (see #22620).
This time I will include a test to ensure this doesn't happen again.