Revert part of "Modernize JS usage in library_pthread.js. NFC" #22620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I guess this is the second time I broke this. We should really have a test for this. |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
|
I uploaded a specific for this this and will make sure I add a test this time: #22623 |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Sep 25, 2024
This was first broken back in emscripten-core#17577 and then fixed in emscripten-core#17752. I then broke it again in emscripten-core#22545 (yay!) (see emscripten-core#22620). This time I will include a test to ensure this doesn't happen again.
|
Thanks! |
sbc100
added a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this PR breaks the fix previously applied in #17752 the comment specifically mentioned not to use for of.
(NOTE: will edit this PR to only remove part of the change, and add a test possibly)