Simplify MIN_NODE_VERSION override from embind ts-gen.#26643
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 7, 2026
Merged
Simplify MIN_NODE_VERSION override from embind ts-gen.#26643sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Followup to emscripten-core#26604. I guess we still need to set `MIN_NODE_VERSION` in case the user specified MIN_NODE_VERSION=-1 (UNSUPPORTED).
brendandahl
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #26604 since we no longer support node v15 or v16.
I guess we still need to set
MIN_NODE_VERSIONin case the user specifiedMIN_NODE_VERSION=-1(UNSUPPORTED).