Skip to content

Simplify MIN_NODE_VERSION override from embind ts-gen. #26643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Apr 7, 2026
+1 −1
Merged

Simplify MIN_NODE_VERSION override from embind ts-gen. #26643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,6 +1959,7 @@ def run_embind_gen(options, wasm_target, js_syms, extra_settings):
# Force node since that is where the tool runs.
if 'node' not in settings.ENVIRONMENT:
settings.ENVIRONMENT.append('node')
settings.MIN_NODE_VERSION = feature_matrix.OLDEST_SUPPORTED_NODE
settings.MINIMAL_RUNTIME = 0
# Required function to trigger TS generation.
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$callRuntimeCallbacks', '$addRunDependency', '$removeRunDependency']
Expand All @@ -1979,7 +1980,6 @@ def run_embind_gen(options, wasm_target, js_syms, extra_settings):
dirname, basename = os.path.split(lib)
if basename == 'libembind.js':
settings.JS_LIBRARIES[i] = os.path.join(dirname, 'libembind_gen.js')
settings.MIN_NODE_VERSION = 160000 if settings.MEMORY64 else 150000
# The final version of the memory64 proposal is not implemented until node
# v24, so we need to lower it away in order to execute the binary at build
# time.
Expand Down
Loading