Fix UINT64_C/INT64_C macros under wasm64#26688
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 15, 2026
Merged
Conversation
kripken
approved these changes
Apr 15, 2026
sbc100
added a commit
that referenced
this pull request
Apr 16, 2026
We were using these in inconsistently, which led to some inconsistencies. Followup to #26688.
Collaborator
|
Nice analysis, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Musl was assuming that 64-bit targets using
longfor int64_t but WebAssembly is a little different to other plaforms in that we uselong longfor int64_t for both 32-bit and 64-bit targets. See http://reviews.llvm.org/D12861.Fixes: llvm/llvm-project#192236