Use clang builtin macros throughout stdint.h and alltypes.h#26689
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 16, 2026
Merged
Use clang builtin macros throughout stdint.h and alltypes.h#26689sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
Author
|
We probably should have done this a long time ago. |
kripken
reviewed
Apr 15, 2026
kripken
approved these changes
Apr 15, 2026
We were using these in inconsistently, which led to some inconsistencies.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 16, 2026
Sadly the reason this slipped through is that we disabled the wasm64 tests recently to save some CI credits.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 16, 2026
Sadly the reason this slipped through is that we disabled the wasm64 tests recently to save some CI credits. Re-enabling `test-wasm64-misc` since its very quick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using these in inconsistently, which led to some inconsistencies.
Followup to #26688.