Skip to content

Update comment about passing --no-shlib-sigcheck when configuring #27494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Aug 6, 2026
+3 −6
Merged

Update comment about passing --no-shlib-sigcheck when configuring #27494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,12 +889,9 @@ def phase_linker_setup(linker_args): # ruff: ignore[complex-structure, too-many
# autoconf declares functions without their proper signatures, and STRICT causes that to trip up by passing --fatal-warnings to the linker.
if settings.STRICT:
exit_with_error('autoconfiguring is not compatible with STRICT')
# AC_CHECK_LIB probes for a symbol by declaring it without a prototype
# (`char foo ();`) and then calling it with no arguments. When the symbol
# comes from an object file or an archive lld only warns about the
# resulting signature mismatch and synthesizes a thunk, but when it comes
# from a shared library the mismatch is a hard error. This turns off the
# shared library check.
# autoconf declares functions without their proper signatures, so turn off shared library signature checks
# TODO: Align defaults for signature checking with static and dynamic linking?
# See https://github.com/llvm/llvm-project/issues/214557
linker_args.append('--no-shlib-sigcheck')

if settings.OPT_LEVEL >= 1:
Expand Down