feat: Phase.hasComponent check against normalized name #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
=========================================
Coverage 34.70% 34.71%
- Complexity 5285 5288 +3
=========================================
Files 700 700
Lines 69569 69575 +6
Branches 7994 7997 +3
=========================================
+ Hits 24147 24150 +3
- Misses 43939 43940 +1
- Partials 1483 1485 +2 ☔ View full report in Codecov by Sentry. |
EvenSol
approved these changes
Mar 21, 2024
asmfstatoil
force-pushed
the
feat_component_names
branch
2 times, most recently
from
6396073
to
9e48978
Compare
feat: new function Phase.getComponentNames fix: check that compnumber is not already in use
asmfstatoil
force-pushed
the
feat_component_names
branch
from
9e48978
to
1b7c922
Compare
normalized / sanitized name returned from |
asmfstatoil
force-pushed
the
feat_component_names
branch
from
6ea6051
to
deb0da0
Compare
asmfstatoil
force-pushed
the
feat_component_names
branch
from
d83e7b2
to
398747b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: new function Phase.getComponentNames