Skip to content

off cron#7690

Merged
Enkhtuvshin0513 merged 1 commit into
mainfrom
cron-off
May 15, 2026
Merged

off cron#7690
Enkhtuvshin0513 merged 1 commit into
mainfrom
cron-off

Conversation

@Batuktech
Copy link
Copy Markdown
Collaborator

@Batuktech Batuktech commented May 15, 2026

Summary by Sourcery

Enhancements:

  • Comment out the tourism API plugin's onServerInit handler to prevent MQ workers from being initialized on server startup.

Summary by CodeRabbit

  • Bug Fixes
    • Disabled a plugin worker initialization to resolve potential issues with the message queue processing.

Review Change Stack

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 15, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Disables the tourism_api plugin's server initialization hook that previously started Redis-backed MQ workers, effectively turning off those background workers on server startup.

File-Level Changes

Change Details Files
Disable initialization of Redis MQ workers during tourism_api plugin server startup.
  • Comment out the onServerInit hook implementation in the tourism_api plugin configuration
  • Prevent initMQWorkers from being invoked with the shared Redis instance on server initialization while leaving the code in place for potential re-enablement
backend/plugins/tourism_api/src/main.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce190b1a-cf0e-4979-bc9e-f32ddc8b4b4f

📥 Commits

Reviewing files that changed from the base of the PR and between 0dc4afd and 0a2d5f0.

📒 Files selected for processing (1)
  • backend/plugins/tourism_api/src/main.ts

📝 Walkthrough

Walkthrough

The tourism API plugin's onServerInit hook that previously initialized MQ workers via initMQWorkers(redis) has been disabled by commenting out the initialization call and its supporting logic.

Changes

MQ Worker Initialization Disabled

Layer / File(s) Summary
Disable MQ worker initialization
backend/plugins/tourism_api/src/main.ts
The onServerInit hook's call to initMQWorkers(redis) is commented out, disabling MQ worker initialization that previously ran at plugin startup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops, and workers rest,
No queues to tend, no tasks to test,
The startup dance is paused with care,
Commented code floats in the air! 🐰

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cron-off

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Enkhtuvshin0513 Enkhtuvshin0513 merged commit e721a33 into main May 15, 2026
10 of 14 checks passed
@Enkhtuvshin0513 Enkhtuvshin0513 deleted the cron-off branch May 15, 2026 05:52
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Instead of commenting out onServerInit, consider guarding initMQWorkers(redis) behind a configuration flag or environment variable so the behavior can be toggled without code changes.
  • If onServerInit is expected to remain disabled long-term, consider removing the handler entirely to avoid confusion about whether MQ workers should still be part of the plugin lifecycle.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Instead of commenting out `onServerInit`, consider guarding `initMQWorkers(redis)` behind a configuration flag or environment variable so the behavior can be toggled without code changes.
- If `onServerInit` is expected to remain disabled long-term, consider removing the handler entirely to avoid confusion about whether MQ workers should still be part of the plugin lifecycle.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants