0.8.0: release sync to main#220
Merged
Merged
Conversation
Needs testing. But the logic checks in my brain
Note: leaving code that never runs in place. Why? Because we are using Drupal's build in Client. If that client changes in the future (and we won't notice until something goes wrong, we will have to deal with error codes ourselves. This should deal with it.
ISSUE-193: Forced Downloads will force everything + check on return code/status
These files will be temporary ... so how to i make sure they are not delete? mmm.. i should be OK ... right? One choice would be to check YET again if the file passed is still there on the CSV queue worker and load if from a string there? mmmm ...
@alliomeria there is a question for you at line 583. I have tons of those. For now i assuming "only process children" if the row containing it was processed. But what if we want to process anyways? Also. another issue i will encounter is: Delete processed ADOs... i will have to parse again each CSV attached to the main one?
Irrelevant but my eye (left one) was twitching
Note: I will also allow any plugin to set Fixed values and skip steps of the AMI setup main form That way we can totally avoid user input on things that need to be one way (like here)
… importer Except it forces CSV and tries to save in private ... if that goes well i might shift all to private
No longer waiting for all CSV rows to be read if that is the case.
adds the $plugin_instance->stepFormAlter($form, $form_state, $this->store, $this->step); only if step >1. Could be really larger than 2 (bc step 2 is the actual plugin form .. but this would also allow a plugin to not define that, but add complex logic for its own $plugin_instance->interactiveForm($parents, $form_state) instead of $plugin_instance->interactiveForm($parents, $form_state);
Since Drupal 10.2 we can't no longer just relay on a 'op' in the input to avoid saving. This here attempts first to check if the VBO operation is happening under the actual Views ROUTE (so the page that the views handles) OR, if someone is using layout builder if 'op' != 'do' (might be another moving target) and there is no batch id.
- Checks if the actual route == view one (for pages) - Checks if either layout builder OR a block and if so if only if op !== "do" and no set id ... no Settings/intermediate form should kick in here, but i will also test with the other plugins (Webform one)
ISSUE-197: Deals with moving target for our VBO Event subscriber conditionals
…custom we will only parse 'ArchiveContainer' 'ArchiveComponent'
only via templates
@alliomeria will give it a spin tomorrow AM. I had to make some hard choices. Automatic UUID generation at this moment of the project is a bad idea. Anything can go wrong, missing ID to generate, repeated UUIDs on the parents, etc, etc. So i will better make the scrip that generates the EAD structure well formed and public and all UUID generation will have there. Once we have tested this the actual script will become part of the process (one can uploads XMLs instead of a CSV)
@alliomeria this has not been my best week. Testing now again nested ingests. Sorry :(
or we will end with 500 Mbytes of stuff that is unneeded on every batch run
See #200 or #200 Note. I think we should also on replace/append and even on full replace log the JSON diff the way we do via VBO replace. @alliomeria thoughts?
ISSUE-195: CSV queue worker and nested CSVs for EAD + an EAD plugin
AMI Update Operations changes: - Change 'replace' Operation to be default - Change 'update' Operation title to "Complete (All JSON keys) Update" instead of "Normal" - Clarify language for each Operation type - Add note linking to documentation and recommendation to test against a single row/object csv. * Update amiSetEntityProcessForm.php
…r is disabled (#206) * Add scheme to config. Also add some more info so we can debug * Add scheme to config. Also add some more info so we can debug * Adds extra check for layout builder assuming maybe there is no route object at all
…perations in AmiUtilityService::preprocessAmiSet and AmiUtilityService::getProcessedAmiSetNodeUUids. Fixes cases where the process is executing under cron or hydroponics and the user is anonymous. (#215)
…ons (#218) * Ensures info['uid'] to be present for both CSV expander and direct processing * Also for delete operation
Member
Author
|
@alliomeria I got it right this time? Ideally this should be merged via either a merge or a rebase and merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs Main with 0.8.0 (latest release)