dont die on bad html but only warn to api logger but dont tell client th...#1514
Merged
JohnMcLear merged 9 commits intodevelopfrom Dec 16, 2013
Merged
dont die on bad html but only warn to api logger but dont tell client th...#1514JohnMcLear merged 9 commits intodevelopfrom
JohnMcLear merged 9 commits intodevelopfrom
Conversation
… that it failed cause html was bad
…ed so early in the function
Member
Author
|
Ready for testing. |
Member
Author
There was a problem hiding this comment.
You set it to nothing before writing to it.
Member
Author
|
I want a second opinion on this as it modifies the output of the content from our API |
Add input validation for html param in setHTML()
JohnMcLear
added a commit
that referenced
this pull request
Dec 16, 2013
dont die on bad html but only warn to api logger but dont tell client th...
Contributor
There was a problem hiding this comment.
just returning here will result in a timeout on the other end, i think. You could add callback(new customError("Malformed html","apierror"));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...at it failed cause html was bad.. Ideally imho we should be able to tell the API client that their request failed because the HTML was bad.