Skip to content

fix(spec,test): 7702 refund block-level gas accounting for EIP-8037#2816

Merged
fselmo merged 4 commits into
ethereum:devnets/bal/7from
fselmo:fix/eip8037-7702-refund
May 7, 2026
Merged

fix(spec,test): 7702 refund block-level gas accounting for EIP-8037#2816
fselmo merged 4 commits into
ethereum:devnets/bal/7from
fselmo:fix/eip8037-7702-refund

Conversation

@fselmo
Copy link
Copy Markdown
Contributor

@fselmo fselmo commented May 6, 2026

🗒️ Description

  • Block-level gas accounting for EIP-7002 refunds for EIP-8037 implementation. Removes tests that locked in the old behavior as the EIP was updated to track the refunds in block-level accounting.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Screenshot 2026-05-06 at 13 13 56

@fselmo fselmo changed the title Fix/eip8037 7702 refund fix(spec,test): 7702 refund block-level gas accounting for EIP-8037 May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (devnets/bal/7@40ce50b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             devnets/bal/7    #2816   +/-   ##
================================================
  Coverage                 ?   85.58%           
================================================
  Files                    ?      630           
  Lines                    ?    39599           
  Branches                 ?     3935           
================================================
  Hits                     ?    33890           
  Misses                   ?     5084           
  Partials                 ?      625           
Flag Coverage Δ
unittests 85.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo fselmo force-pushed the fix/eip8037-7702-refund branch from ccad584 to 2985319 Compare May 6, 2026 19:57
@fselmo fselmo marked this pull request as ready for review May 6, 2026 20:00
@fselmo fselmo requested a review from spencer-tb May 6, 2026 20:00
@fselmo fselmo changed the title fix(spec,test): 7702 refund block-level gas accounting for EIP-8037 fix(spec,test): 7702 refund block-level gas accounting for EIP-8037; update state byte sizes May 6, 2026
@fselmo fselmo marked this pull request as draft May 6, 2026 21:17
@fselmo fselmo changed the title fix(spec,test): 7702 refund block-level gas accounting for EIP-8037; update state byte sizes fix(spec,test): 7702 refund block-level gas accounting for EIP-8037 May 6, 2026
@fselmo fselmo marked this pull request as ready for review May 6, 2026 21:28
@LouisTsai-Csie

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the 7702 spec change. I'd update the title/desc to mention the additional param updates. A rebase onto latest and fill check seems like the next steps!

@fselmo fselmo force-pushed the fix/eip8037-7702-refund branch from 4ecc49d to 5e3339d Compare May 7, 2026 17:20
@fselmo
Copy link
Copy Markdown
Contributor Author

fselmo commented May 7, 2026

Should these be changed too?

I only pushed these here to check the failures. I will PR the bytes updates separately.

@fselmo
Copy link
Copy Markdown
Contributor Author

fselmo commented May 7, 2026

LGTM on the 7702 spec change. I'd update the title/desc to mention the additional param updates. A rebase onto latest and fill check seems like the next steps!

Ah I meant to revert the bytes change commit. Was just testing it out to see what broke. I will PR this separately. Will wait until CI runs here and merge this as 7702 change only.

@fselmo fselmo merged commit 5416cbb into ethereum:devnets/bal/7 May 7, 2026
23 checks passed
@fselmo fselmo deleted the fix/eip8037-7702-refund branch May 7, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants